gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() by sethmlarson · Pull Request #158503 · python/cpython

sethmlarson · 2026-09-30T14:13:56Z

Issue: Validate SSLContext.wrap_bio() parameters like wrap_socket() #156793

…socket() Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

read-the-docs-community · 2026-09-30T14:17:47Z

Documentation build overview

📚 cpython-previews | 🛠️ Build #34854436 | 📁 Comparing 490f9df against main (069c74a)

🔍 Preview build

4 files changed

± library/asyncio-eventloop.html
± library/asyncio-stream.html
± library/ssl.html
± whatsnew/changelog.html

miss-islington-app · 2026-09-30T15:31:23Z

Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14, 3.15.
🐍🍒⛏🤖

miss-islington-app · 2026-09-30T15:31:27Z

Sorry, @sethmlarson and @hugovk, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1697ea386c707142555d98a1263176bbbc014a96 3.15

miss-islington-app · 2026-09-30T15:31:46Z

Sorry, @sethmlarson and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1697ea386c707142555d98a1263176bbbc014a96 3.12

bedevere-app · 2026-09-30T15:31:47Z

GH-158509 is a backport of this pull request to the 3.14 branch.

miss-islington-app · 2026-09-30T15:31:51Z

Sorry, @sethmlarson and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1697ea386c707142555d98a1263176bbbc014a96 3.11

bedevere-app · 2026-09-30T15:31:55Z

GH-158510 is a backport of this pull request to the 3.13 branch.

miss-islington-app · 2026-09-30T15:31:55Z

Sorry, @sethmlarson and @hugovk, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1697ea386c707142555d98a1263176bbbc014a96 3.10

bedevere-app · 2026-09-30T15:44:10Z

GH-158511 is a backport of this pull request to the 3.15 branch.

bedevere-app · 2026-09-30T15:48:05Z

GH-158513 is a backport of this pull request to the 3.12 branch.

bedevere-app · 2026-09-30T15:51:56Z

GH-158516 is a backport of this pull request to the 3.11 branch.

bedevere-app · 2026-09-30T15:58:41Z

GH-158518 is a backport of this pull request to the 3.10 branch.

…_socket() (GH-158503) (#158511) Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…_socket() (GH-158503) (#158509) Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

…_socket() (GH-158503) (#158510) Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

…_socket() (GH-158503) (#158513) * [3.12] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) (cherry picked from commit 1697ea3) * Raise a DeprecationWarning instead of ValueError Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: T. Wouters <thomas@python.org>

bedevere-app · 2026-09-30T21:36:17Z

GH-158532 is a backport of this pull request to the 3.11 branch.

bedevere-app · 2026-09-30T21:45:11Z

GH-158533 is a backport of this pull request to the 3.10 branch.

…_socket() (GH-158503) (#158532) [3.11] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) (GH-158513) * [3.12] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) (cherry picked from commit 1697ea3) * Raise a DeprecationWarning instead of ValueError (cherry picked from commit 869069d) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…_socket() (GH-158503) (#158533) * [3.10] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) (GH-158513) * [3.12] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) (cherry picked from commit 1697ea3) * Raise a DeprecationWarning instead of ValueError (cherry picked from commit 869069d) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: T. Wouters <thomas@python.org> * gh-156793: Start the SSL handshake in the 3.10 hostname validation tests --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <pablogsal@gmail.com>

…e wrap_socket() (pythonGH-158503) (python#158533) * [3.10] pythongh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (pythonGH-158503) (pythonGH-158513) * [3.12] pythongh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (pythonGH-158503) (cherry picked from commit 1697ea3) * Raise a DeprecationWarning instead of ValueError (cherry picked from commit 869069d) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: T. Wouters <thomas@python.org> * pythongh-156793: Start the SSL handshake in the 3.10 hostname validation tests --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <pablogsal@gmail.com> (cherry picked from commit 5867d4e)

pythongh-156793: Validate SSLContext.wrap_bio() parameters like wrap_…

6dc0069

…socket() Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

sethmlarson added the type-security A security issue label Sep 30, 2026

sethmlarson requested review from 1st1, gpshead and picnixz as code owners September 30, 2026 14:13

sethmlarson added the needs backport to 3.10 label Sep 30, 2026

sethmlarson requested review from asvetlov, kumaraditya303 and willingc as code owners September 30, 2026 14:13

sethmlarson added the release-blocker label Sep 30, 2026

github-project-automation Bot added this to Release and Deferred blockers 🚫 Sep 30, 2026

sethmlarson added topic-SSL needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 30, 2026

bedevere-app Bot mentioned this pull request Sep 30, 2026

Validate SSLContext.wrap_bio() parameters like wrap_socket() #156793

Closed

bedevere-app Bot added the awaiting core review label Sep 30, 2026

hugovk reviewed Sep 30, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Security/2026-09-16-14-05-19.gh-issue-156793.Qa1T5Z.rst Outdated

Fix news RST

490f9df

Yhg1s approved these changes Sep 30, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 30, 2026

hugovk enabled auto-merge (squash) September 30, 2026 14:32

hugovk merged commit 1697ea3 into python:main Sep 30, 2026
97 of 99 checks passed

bedevere-app Bot removed the awaiting merge label Sep 30, 2026

miss-islington-app Bot assigned hugovk Sep 30, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 30, 2026

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 30, 2026

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 30, 2026

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 30, 2026

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 30, 2026

sethmlarson deleted the wrap-bio-parameters branch September 30, 2026 15:57

bedevere-app Bot removed the needs backport to 3.10 label Sep 30, 2026

Yhg1s mentioned this pull request Sep 30, 2026

[3.11] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) #158532

Merged

Yhg1s mentioned this pull request Sep 30, 2026

[3.10] gh-156793: Validate SSLContext.wrap_bio() parameters like wrap_socket() (GH-158503) #158533

Merged

serhiy-storchaka mentioned this pull request Oct 9, 2026

[3.15] gh-156106: Add tests for setting and deleting attributes defined in C (GH-156107) #159086

Merged

Conversation

sethmlarson commented Sep 30, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

read-the-docs-community Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Sep 30, 2026

Uh oh!

miss-islington-app Bot commented Sep 30, 2026

Uh oh!

miss-islington-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

miss-islington-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

miss-islington-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sethmlarson commented Sep 30, 2026 •

edited by bedevere-app Bot

Loading

read-the-docs-community Bot commented Sep 30, 2026 •

edited

Loading